Improve RecordShowPage Header performances #6440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR focuses on enhancing the performance of the RecordShowPage header by refactoring and optimizing the logic.
- Removed
useEffectinuseRecordShowPagePagination.ts: UtilizedonCompletedprop ofuseFindManyRecordsto settotalCountstate, reducing unnecessary re-renders. - Refactored
RecordShowPage.tsx: IntroducedRecordShowPageHeadercomponent to encapsulate header logic, isolating state and logic to prevent full-page re-renders. - Added
RecordShowPageHeader.tsx: New component to manage header logic and pagination, improving performance by isolating state and logic.
3 file(s) reviewed, 2 comment(s)
Edit PR Review Bot Settings
| }: { | ||
| objectNameSingular: string; | ||
| objectRecordId: string; | ||
| headerIcon: React.ComponentType; |
There was a problem hiding this comment.
Spelling: The headerIcon prop is defined but not used in the component. It should be removed from the props list.
| navigateToIndexView, | ||
| } = useRecordShowPagePagination(objectNameSingular, objectRecordId); | ||
|
|
||
| const { headerIcon } = useRecordShowPage(objectNameSingular, objectRecordId); |
There was a problem hiding this comment.
Logic: Redundant call to useRecordShowPage for headerIcon. This can be optimized by passing headerIcon directly as a prop from the parent component.
martmull
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I am: